Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_mssql_server: Set azuread_administrator inline on creation #13753

Merged
merged 1 commit into from
Oct 20, 2021
Merged

azurerm_mssql_server: Set azuread_administrator inline on creation #13753

merged 1 commit into from
Oct 20, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Oct 15, 2021 •
edited
Loading

Fixes #13677

Besides:

Acceptance tests

❯ go install && make acctests SERVICE='mssql' TESTARGS='-run=TestAccMsSqlServer_azureadAdminUpdate'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/mssql -run=TestAccMsSqlServer_azureadAdminUpdate -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMsSqlServer_azureadAdminUpdate
=== PAUSE TestAccMsSqlServer_azureadAdminUpdate
=== CONT  TestAccMsSqlServer_azureadAdminUpdate
--- PASS: TestAccMsSqlServer_azureadAdminUpdate (904.20s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mssql    905.764s

@aristosvo aristosvo force-pushed the mssql/set-server-azuread-administrator-inline-on-creation branch from c75dcdb to cce6be5 Compare October 15, 2021 10:47
@aristosvo aristosvo force-pushed the mssql/set-server-azuread-administrator-inline-on-creation branch from cce6be5 to 4d80549 Compare October 15, 2021 12:53
@katbyte katbyte added the service/mssql Microsoft SQL Server label Oct 15, 2021
@katbyte katbyte added this to the v2.82.0 milestone Oct 15, 2021
@aristosvo aristosvo mentioned this pull request Oct 18, 2021
Merged
katbyte
katbyte approved these changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM 💯

@katbyte katbyte merged commit 06c7801 into hashicorp:main Oct 20, 2021
katbyte added a commit that referenced this pull request Oct 20, 2021
@katbyte
CHANGELOG.md for #13753
99c0f30
@github-actions
Copy link

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
service/mssql Microsoft SQL Server size/M
Projects
None yet
Milestone
v2.82.0
Development

Successfully merging this pull request may close these issues.

Create Azure SQL Server and Azure AD administrators in same request
2 participants
@aristosvo @katbyte